https://bugs.documentfoundation.org/show_bug.cgi?id=170384
--- Comment #1 from Hossein <[email protected]> --- Looking into BitmapFilterTest.cxx, at the moment it contains 22 tests for 12 distinct filters: $ git grep -h BitmapFilterTest vcl/qa/cppunit/BitmapFilterTest.cxx|awk '{print substr($2, 1, length($2)-1)}' testClampAlpha_24_BPP testClampAlpha_32_BPP testBlurCorrectness_24_BPP testBlurCorrectness_32_BPP testBasicMorphology testPerformance_24_BPP testPerformance_32_BPP testGenerateStripRanges testMultiplyBlendFilter_24_BPP testMultiplyBlendFilter_32_BPP testNormalBlendFilter_24_BPP testNormalBlendFilter_32_BPP testDarkenBlendFilter_24_BPP testDarkenBlendFilter_32_BPP testLightenBlendFilter_24_BPP testLightenBlendFilter_32_BPP testScreenBlendFilter_24_BPP testScreenBlendFilter_32_BPP testArithmeticBlendFilter_24_BPP testArithmeticBlendFilter_32_BPP testDuoToneFilter_24_BPP testDuoToneFilter_32_BPP 32 Bitmap filters can be be found in vcl/source/bitmap/: $ ls vcl/source/bitmap/*Filter.cxx|wc -l 32 You may compare the names in these two, and find the missing ones. For each of the missing tests, first you should understand the purpose of the filter, and then come up with an idea to test the filter. Then, you should create two functions for 24 and 32 bit bitmap. In the implementation(s), you should make sure that the filter generates an expected output when it modifies the bitmap. This is usually done by checking the modified bitmap after the filter is applied with BitmapFilter::Filter(). -- You are receiving this mail because: You are the assignee for the bug.
