https://bugs.documentfoundation.org/show_bug.cgi?id=170675
Bug ID: 170675
Summary: Update Writer's user defined bullet config helper code
Product: LibreOffice
Version: 26.2.0.3 release
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: enhancement
Priority: medium
Component: Writer
Assignee: [email protected]
Reporter: [email protected]
Depends on: 169441
Blocks: 103369
There was some old Writer code for user bullet configuration:
https://github.com/LibreOffice/core/blob/master/sw/source/core/doc/number.cxx
See SwDefBulletConfig. The config path used was:
Office.Writer/Numbering/DefaultBulletList
This config has been superseded, see details in bug 169441, the config paths
(with slightly different notation) for the symbols and corresponding fonts are:
- officecfg::Office::Common::BulletsNumbering::DefaultListBullets
- officecfg::Office::Common::BulletsNumbering::DefaultListBulletsFonts
The old SwDefBulletConfig is still used in some places in the code, these are
all the references:
sw/inc/numrule.hxx:290: bool IsDefBulletFontUserDefined();
sw/source/core/doc/number.cxx:1488: bool IsDefBulletFontUserDefined()
sw/source/core/edit/autofmt.cxx:1562: if (
numfunc::IsDefBulletFontUserDefined() )
sw/source/filter/html/htmlnumreader.cxx:96: if (
numfunc::IsDefBulletFontUserDefined() )
sw/source/filter/html/htmlnumreader.cxx:378: if (
numfunc::IsDefBulletFontUserDefined() )
sw/source/filter/html/htmlnumreader.cxx:491: if (
numfunc::IsDefBulletFontUserDefined() )
sw/source/filter/md/swmd.cxx:337: if
(numfunc::IsDefBulletFontUserDefined())
sw/source/filter/md/swmd.cxx:424: if
(numfunc::IsDefBulletFontUserDefined())
sw/source/filter/md/swmd.cxx:515: if
(numfunc::IsDefBulletFontUserDefined())
sw/source/uibase/wrtsh/wrtsh1.cxx:1657: if (
numfunc::IsDefBulletFontUserDefined() )
The configs should be unified, perhaps the old config class should be updated
to encompass the new config.
If there's interest to have this outside of Writer as well, then it could be
moved to a more generic place.
The structure of the old config was different:
- there was a single config for the font, font weight and italic setting for
all configured bullets,
- the list items could be specified by the numeric IDs of the characters, and
there was no wrap-around like with the new config (ie. if you specify only the
first few levels, now they'll repeat on subsequent levels).
It also wasn't working until this commit since 25.8.5:
b0510011e9857f418c02b838d9fdb5769a912c70.
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=103369
[Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=169441
[Bug 169441] Decouple bullet library items from default levels
--
You are receiving this mail because:
You are the assignee for the bug.
