https://bugs.documentfoundation.org/show_bug.cgi?id=170982
Bug ID: 170982
Summary: Wrong presentation strings for Asian Typography
paragraph items (Forbidden Rules and Script Space)
Product: LibreOffice
Version: 3.3.0 release
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: minor
Priority: medium
Component: LibreOffice
Assignee: [email protected]
Reporter: [email protected]
Description:
In `include/editeng/editrids.hrc`, two of the three Asian Typography paragraph
item presentation strings are incorrect. These strings are used by
`GetPresentation()` in `editeng/source/items/paraitem.cxx` to describe the item
state (e.g. in the Style Organizer "Contains" description).
1) **Forbidden Rules: strings are swapped** (lines 279-280)
Currently:
```
RID_SVXITEMS_FORBIDDEN_RULE_OFF = "Apply list of forbidden characters to
beginning and end of lines"
RID_SVXITEMS_FORBIDDEN_RULE_ON = "Don't apply list of forbidden characters to
beginning and end of lines"
```
The OFF string says "Apply" and the ON string says "Don't apply", which is the
opposite of what they should be. In `SvxForbiddenRuleItem::GetPresentation()`,
`!GetValue()` selects the OFF string, so when the value is `true` (feature
enabled), the ON string is used — but it says "Don't apply".
Should be:
```
RID_SVXITEMS_FORBIDDEN_RULE_OFF = "Don't apply list of forbidden characters to
beginning and end of lines"
RID_SVXITEMS_FORBIDDEN_RULE_ON = "Apply list of forbidden characters to
beginning and end of lines"
```
2) **Script Space: ON and OFF strings are identical** (lines 275-276)
Currently:
```
RID_SVXITEMS_SCRPTSPC_OFF = "No automatic character spacing"
RID_SVXITEMS_SCRPTSPC_ON = "No automatic character spacing"
```
Both say "No automatic character spacing". The ON string should be:
```
RID_SVXITEMS_SCRPTSPC_ON = "Automatic character spacing"
```
For reference, the third Asian Typography item (Hanging Punctuation, lines
277-278) is correct:
```
RID_SVXITEMS_HNGPNCT_OFF = "No hanging punctuation at line end"
RID_SVXITEMS_HNGPNCT_ON = "Hanging punctuation at line end"
```
Steps to reproduce:
1. Create a paragraph style inheriting from Default
2. In the style dialog, go to Asian Typography tab
3. Change the "Apply list of forbidden characters" or "Apply spacing between
Asian and non-Asian text" checkboxes
4. Go to the General tab and look at the "Contains" description
Expected: The description matches the checkbox state
Actual: Forbidden Rules shows the opposite state; Script Space shows "No
automatic character spacing" regardless of the setting
The fix is a two-line change in `include/editeng/editrids.hrc`.
Steps to Reproduce:
see above
Actual Results:
see above
Expected Results:
see above
Reproducible: Always
User Profile Reset: No
Additional Info:
see above
--
You are receiving this mail because:
You are the assignee for the bug.
