https://bugs.documentfoundation.org/show_bug.cgi?id=141381

--- Comment #11 from [email protected] ---
(In reply to Michael Weghorn from comment #10)
> (In reply to Heiko Tietze from comment #9)
> > But the SizableToolWindow has probably by design no minimize/maximize button
> > to keep the titlebar simple/small. The save dialog might serve as an
> > example.
> 
> As you mention, the native Windows file dialog also doesn't show a maximize
> button, also when triggered from other applications.

I see the comparison, but I would argue the use case differs significantly. A
"File Open" dialog is transient (search, click, gone). The CSV Import dialog,
however, is often a data-heavy workspace where users need to verify column
separation across many rows and wide tables. Hiding the maximize capability
here decreases discoverability for a feature that is functionally necessary,
not just cosmetic.

> > However, double-clicking the header still maximizes the window -
> > and we should make at least this happen.
> 
> Sounds like a potential good solution to me if adding the maximize button is
> not desirable.

I investigated implementing this "double-click without button" approach, but:

In `salframe.cxx` (ImplSalCreateFrame), VCL actively enforces that windows
without a maximize button also lose the maximize functionality in the system
menu:

    if ( !(nSysStyle & WS_MAXIMIZEBOX) )
        DeleteMenu( hSysMenu, SC_MAXIMIZE, MF_BYCOMMAND );

This line removes the `SC_MAXIMIZE` command if the button style is missing.
This effectively kills the double-click behavior and the context menu entry.
To support "double-click without button", we would have to modify this
menu-deletion logic as well.

> @Reporter: What do you think?

Given the above, enabling "double-click only" would require a deeper and
riskier change to the generic VCL menu logic. 
In contrast, simply allowing the button (via the one-liner proposed) is
technically clean, low-risk, and provides better UX affordance. Since
KWin/Linux already shows the button safely, I prefer enabling the button on
Windows as well, by the patch above.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to