https://bugs.documentfoundation.org/show_bug.cgi?id=173811
BogdanB <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|bibisectRequest |bibisected, bisected Regression By| |Miklos Vajna Blocks| |139532 CC| |[email protected] --- Comment #5 from BogdanB <[email protected]> --- commit b973401c5698135da831dbadca083a8f9d356a60 Author: Miklos Vajna <[email protected]> Date: Fri Sep 15 13:37:41 2023 +0200 Related: tdf#55160 sw floattable, nested DOCX imp: fix inner tbl at cell start The bugdoc has an outer table and also two inner tables: the problematic one is the floating table anchored at the start of B1, which should float but does not. This special-casing was added in commit c1eebcdac9f2b289fd363399130c485ca5ff444c (tdf#79329 DOCX import: fix missing outer table with floattable at cell start, 2016-11-08), because there was no easy way to make sure that an inner floating table at cell start keeps the outer table import working, and having 2 inline tables is better than having an inner floating table and no outer table at all. The root of the problem is that in case an SwXParagraph tracks the outer cell start and we have an inner floating table, then the inner conversion to text frame will invalidate that SwXParagraph, so the outer table conversion will fail. Fix the problem by creating a cursor at cell start, moving it away, performing the inner table resolution. And in case the cell start SwXParagraph is now invalid, then move the cursor back and work with that position. The original bugdoc has 2 floating tables at cell start, which is still broken, but this approach allows fixing that in a later commit; while the old approach simply didn't notice that the 2nd floating table is also at cell start. Change-Id: Iedad7b2f023e88dfc5de7875ebc00320c2e6ad65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156937 Reviewed-by: Miklos Vajna <[email protected]> Tested-by: Jenkins (cherry picked from commit 2d43c34333076fad092f0cdc0f60f81580acdbee) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157054 Reviewed-by: Xisco Fauli <[email protected]> Miklos, please can you take a look? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139532 [Bug 139532] [META] DOCX (OOXML) Floating table related issues -- You are receiving this mail because: You are the assignee for the bug.
