https://bugs.freedesktop.org/show_bug.cgi?id=60805

--- Comment #12 from Noel Power <[email protected]> ---
(In reply to comment #11)
> (In reply to comment #10)
> > So, reverting that commit will not fix this fundamental issue, I'm afraid. 
> > With deep regrets, I had to revert the above revert.
> > 
> 
> I don't believe restoring hack to turn off antialiasing for border drawing
> is any better of a solution, can only judge from my own system where the
> opposite seems to be better e.g. always turning it on. But... whatever,
> returning this to the list

just to make it clear, the orig patch that I reverted ( that causes this bug )
was committed to solve some problem with 'thicker' than expected borders, I
can't tell whether this patch still fixes this ( I suspect not ) but I have no
details or document to check against as there is no bug number associated with
that patch. However I don't see ( and haven't seen ) any such issue in the test
document or other's I have looked at ( that's not to say it doesn't happen,
just I can't tell any more than what I have experienced ) I have a feeling
though that perhaps these border issues might have been improved/fixed by
various fixes from mstahl regarding hairline border detection and clipping.

The test document contains a pretty nice set of cells with various border
styles and border line widths, in every instance with the patch mentioned above
'reverted' the display seems to be much much better. In fact in addition to the
dissapearing border lines I also see lots of nasty artefacts in the border
display [1] ( even at 100% zoom ) and additionally border width differences
that don't seem to show up [2]( e.g. much thicker lines appearing the same as
thinner ones ) [3] double line border appearing to be filled in


[1] look at the jagged border intersection with cells marked 62,63
[2] look at cells marked 53,54 the line width of 54 is twice that of 53 but it
looks the same
[3] the funny thick borders on parts of the cells marked with 74,75 ( see
bottom of the screen shot )


Regardless of what the 'proper' solution might be ( and yes probably some deep
analysis by some drawninglayer enabled person needed to fix that ) I don't
think hard coding the antialiasing to off when drawing calc cell borders which
seems to clearly make things worse is the correct solution.

at the very least imho that patch *should* be reverted at least to give users
some flexibility.

I think at least this bug is serious enough that it be on the 4.0 MAB

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to