https://bugs.freedesktop.org/show_bug.cgi?id=38929

--- Comment #18 from Milan Bouchet-Valat <[email protected]> ---
Still present with LO 4.1.0.4.

I think I have found the root problem in this bug (see below). Any chance to
get some attention?

In the attached testcase (see XML extracts below), bold font is determined both
by cell-level text styles, and by inside-cell paragraph and text styles. The
state of the Bold button in the toolbar only reflects the attributes of
inside-cell text styles. So when one cell has bold font set by an inside-cell
text style, the Bold button considers bold is enabled: when you click on it,
Impress tries to disable bold font. This results in both cell-level (ce1) and
inside-cell (P1) paragraph styles to be updated, but not change is visible
since inside-cell text style (T1) already specified that no bold font should be
used, which contradicted ce1.

Likewise, the inside-cell text style for the second cell (T2) is not updated,
so it continues to specify a bold font. When selecting both cells, the Bold
button is still enabled. Yet, when toggling it, ce1 and P1 are changed to
*enable* bold (instead of disabling it as it should), which again has no
effect.

So the main issue is that T2 is never updated. But there seem to be other
inconsistencies that may be a consequence of this failure to update this style.



XML details:

In the attached testcase, the XML for the table is:
<table:table table:template-name="default" table:use-first-row-styles="true"
table:use-banding-rows-styles="true">
  <table:table-column table:style-name="co1"/>
  <table:table-row table:style-name="ro1">
    <table:table-cell table:style-name="ce1">
      <text:p text:style-name="P1">
        <text:span text:style-name="T1">Test1</text:span>
     </text:p>
   </table:table-cell>
  </table:table-row>
  <table:table-row table:style-name="ro1">
    <table:table-cell table:style-name="ce1">
      <text:p text:style-name="P1">
        <text:span text:style-name="T2">Test2</text:span>
        </text:p></table:table-cell>
  </table:table-row>
</table:table>

What changes when disabling bold font while selecting both cells is cell styles
P1 and T1:
 <style:style style:name="ce1" style:family="table-cell">
 <style:graphic-properties draw:fill="solid" draw:fill-color="#e6e6e6"
style:repeat="repeat" draw:textarea-vertical-align="middle"
fo:padding-top="0.1cm" fo:padding-bottom="0.1cm" fo:padding-left="0.1cm"
fo:padding-right="0.1cm"/>
 <style:paragraph-properties fo:text-align="start" fo:border="none"/>
-<style:text-properties style:font-name="DejaVu Serif" fo:font-size="28pt"
fo:font-style="normal" fo:font-weight="bold" style:font-size-asian="28pt"
style:font-style-asian="normal" style:font-weight-asian="bold"
style:font-size-complex="28pt" style:font-style-complex="normal"
style:font-weight-complex="bold"/>
+<style:text-properties style:font-name="DejaVu Serif" fo:font-size="28pt"
fo:font-style="normal" fo:font-weight="normal" style:font-size-asian="28pt"
style:font-style-asian="normal" style:font-weight-asian="normal"
style:font-size-complex="28pt" style:font-style-complex="normal"
style:font-weight-complex="normal"/>
 </style:style>
 <style:style style:name="P1" style:family="paragraph">
 <style:paragraph-properties fo:text-align="start"/>
+<style:text-properties fo:font-weight="normal"
style:font-weight-asian="normal" style:font-weight-complex="normal"/>
 </style:style>
 <style:style style:name="T1" style:family="text">
 <style:text-properties style:font-name="DejaVu Serif" fo:font-size="18pt"
fo:font-style="normal" fo:font-weight="normal" style:font-size-asian="18pt"
style:font-style-asian="normal" style:font-weight-asian="normal"
style:font-size-complex="18pt" style:font-style-complex="normal"
style:font-weight-complex="normal"/>

And when trying again to disable bold with both cells selected, the inverse
change happens:
<style:style style:name="ce1" style:family="table-cell">
 <style:graphic-properties draw:fill="solid" draw:fill-color="#e6e6e6"
style:repeat="repeat" draw:textarea-vertical-align="middle"
fo:padding-top="0.1cm" fo:padding-bottom="0.1cm" fo:padding-left="0.1cm"
fo:padding-right="0.1cm"/>
 <style:paragraph-properties fo:text-align="start" fo:border="none"/>
-<style:text-properties style:font-name="DejaVu Serif" fo:font-size="28pt"
fo:font-style="normal" fo:font-weight="normal" style:font-size-asian="28pt"
style:font-style-asian="normal" style:font-weight-asian="normal"
style:font-size-complex="28pt" style:font-style-complex="normal"
style:font-weight-complex="normal"/>
+<style:text-properties style:font-name="DejaVu Serif" fo:font-size="28pt"
fo:font-style="normal" fo:font-weight="bold" style:font-size-asian="28pt"
style:font-style-asian="normal" style:font-weight-asian="bold"
style:font-size-complex="28pt" style:font-style-complex="normal"
style:font-weight-complex="bold"/>
 </style:style>
 <style:style style:name="P1" style:family="paragraph">
 <style:paragraph-properties fo:text-align="start"/>
-<style:text-properties fo:font-weight="normal"
style:font-weight-asian="normal" style:font-weight-complex="normal"/>
+<style:text-properties style:font-name="DejaVu Serif" fo:font-weight="bold"
style:font-weight-asian="bold" style:font-weight-complex="bold"/>
 </style:style>
 <style:style style:name="T1" style:family="text">
 <style:text-properties style:font-name="DejaVu Serif" fo:font-size="18pt"
fo:font-style="normal" fo:font-weight="normal" style:font-size-asian="18pt"
style:font-style-asian="normal" style:font-weight-asian="normal"
style:font-size-complex="18pt" style:font-style-complex="normal"
style:font-weight-complex="normal"/>

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to