https://bugs.freedesktop.org/show_bug.cgi?id=68396

Julien Nabet <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #5 from Julien Nabet <[email protected]> ---
masc: thank you for your feedback.

Caolán: user's bts show this:
0   libvcllo.dylib                    0x01a29eec Window::GetParent() const + 12
1   libvcllo.dylib                    0x01a309bc
Window::ImplIsRealParentPath(Window const*) const + 44
2   libvcllo.dylib                    0x01a30a1c
Window::ImplSetFrameParent(Window const*) + 60
3   libvcllo.dylib                    0x01a403ff Window::SetParent(Window*) +
95
4   libvcllo.dylib                    0x01a056c7
SplitWindow::RemoveItem(unsigned short, unsigned char) + 167
5   libsfxlo.dylib                    0x00624a17
SfxSplitWindow::RemoveWindow(SfxDockingWindow*, unsigned char) + 247
6   libsfxlo.dylib                    0x005ec4f0
SfxDockingWindow::ReleaseChildWindow_Impl() + 544
7   libsfxlo.dylib                    0x005ec67b
SfxDockingWindow::~SfxDockingWindow() + 43
8   libsfxlo.dylib                    0x00638e3d
SfxTemplateDialog::~SfxTemplateDialog() + 61
9   libsfxlo.dylib                    0x0052bf8a
SfxChildWindow::~SfxChildWindow() + 58
10  libsfxlo.dylib                    0x00642ac8
SfxTemplateDialogWrapper::~SfxTemplateDialogWrapper() + 40
11  libsfxlo.dylib                    0x0052c4a8 SfxChildWindow::Destroy() +
328
12  libsfxlo.dylib                    0x00577393
SfxWorkWindow::DeleteControllers_Impl() + 211

A search on ImplIsRealParentPath gives this:
   1476 sal_Bool Window::ImplIsRealParentPath( const Window* pWindow ) const
   1477 {
   1478     pWindow = pWindow->GetParent();
   1479     while ( pWindow )
   1480     {
   1481         if ( pWindow == this )
   1482             return sal_True;
   1483         pWindow = pWindow->GetParent();
   1484     }
   1485 
   1486     return sal_False;
   1487 }
(see
http://opengrok.libreoffice.org/xref/core/vcl/source/window/window.cxx#1476)

Shouldn't pWindow be tested before calling GetParent() on it line 1478?
(BTW, I don't know why pWindow would be NULL here)

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to