https://bugs.freedesktop.org/show_bug.cgi?id=70160

Jan Holesovsky <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[email protected] |[email protected]
                   |desktop.org                 |
             Blocks|                            |65675

--- Comment #2 from Jan Holesovsky <[email protected]> ---
Adding to Most Annoying bugs.

Prashant: The problem is that mpSplitSet->mpItems[mnSplitPos].mnMaxSize can be
-1 (meaning no limit) which here turns into -1 always; but even if we do
something like

--- a/vcl/source/window/splitwin.cxx
+++ b/vcl/source/window/splitwin.cxx
@@ -2559,12 +2559,14 @@ void SplitWindow::Tracking( const TrackingEvent& rTEvt
)

                 // where is the sidebar is attached?
                 if ( (mpSplitSet == mpMainSet) && mbBottomRight )
-                    nNewSize = mnMaxSize - mnMStartPos; // right hand side of
the screen
+                    nNewSize = mnMaxSize - mnMSplitPos; // right hand side of
the screen
                 else
-                    nNewSize = mnMStartPos; // left hand side of the screen
+                    nNewSize = mnMSplitPos; // left hand side of the screen

                 // do not make the sidebar wider than mnMaxSize
-                nNewSize = std::min(nNewSize,
mpSplitSet->mpItems[mnSplitPos].mnMaxSize);
+                nNewSize = std::max(nNewSize, 0L);
+                if (mpSplitSet->mpItems[mnSplitPos].mnMaxSize > 0)
+                    nNewSize = std::min(nNewSize,
mpSplitSet->mpItems[mnSplitPos].mnMaxSize);

                 SplitItem( mpSplitSet->mpItems[mnSplitPos].mnId, nNewSize,
                            bPropSmaller, bPropGreater );


there are still some corner cases that need to sort out, namingly:

* F5 + dock it
* make the Writer window smaller
* move the handle with the mouse to 0 and back, and see how the navigator keeps
growing until it fills the entire window

Please have a look :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to