https://bugs.freedesktop.org/show_bug.cgi?id=72391
Lionel Elie Mamane <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|[email protected] |[email protected] |desktop.org | CC| |[email protected] Blocks| |65675 --- Comment #11 from Lionel Elie Mamane <[email protected]> --- @noelgrandin: this comes from the commit below. aStr.equalsAsciiL( "%", 1 ) is NOT equivalent to aStr.startsWith( "%" ) but it is equivalent to aStr == "%" Could you please check/correct the rest of your commit, and any similar ones? Thanks. By contrast, aStr.compareToAscii( "%", 1 ) == 0 is equivalent to aStr.startsWith( "%" ) commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3 Author: Noel Grandin <[email protected]> Date: Tue Nov 19 12:47:37 2013 +0200 convert equalsAsciiL calls to startWith calls where possible Simplify code like: aStr.equalsAsciiL( "%", 1 ) to aStr.startsWith( "%" ) Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00 diff --git a/reportdesign/source/filter/xml/xmlExport.cxx b/reportdesign/source/filter/xml/xmlExport.cxx index 475c489..954bce4 100644 --- a/reportdesign/source/filter/xml/xmlExport.cxx +++ b/reportdesign/source/filter/xml/xmlExport.cxx @@ -1020,7 +1020,7 @@ void ORptExport::exportContainer(const Reference< XSection>& _xSection) OUString ORptExport::convertFormula(const OUString& _sFormula) { OUString sFormula = _sFormula; - if ( _sFormula.equalsAsciiL("rpt:",4) ) + if ( _sFormula.startsWith("rpt:") ) sFormula = ""; return sFormula; } -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
