https://bugs.freedesktop.org/show_bug.cgi?id=68959
Michael Stahl <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|[email protected] |[email protected] |desktop.org | CC| |[email protected] See Also| |https://bugs.freedesktop.or | |g/show_bug.cgi?id=71714 Version|4.1.1.1 rc |4.1.0.0.beta2 --- Comment #3 from Michael Stahl <[email protected]> --- regression from: commit f22006dc6ac34a35a060e15466cf6b2d2058617d Author: Luboš Luňák <[email protected]> AuthorDate: Wed Apr 17 18:52:28 2013 +0200 fix stupid over-optimization There's so little to be gained by storing pointers to simple or refcounted types instead of using an instance. At least SwTxtNode::GetMinMaxSize() and SwTxtNode::GetScalingOfSelectedText() pass string temporaries to SwDrawTextInfo, so keeping a pointer is clearly broken, and MSVC manages to optimize the code enough to crash because of this. As all the pointers point to const references and are accesses using const references as well, there shouldn't be any harm in making a copy. This fixes smoketest crash on Windows. ... specifically the change to convert "pPos" from Point const* to Point means that SwDrawTextInfo::Shift() and SwDoDrawStretchCapital::Do() (which used to modify the "const Point", eek!) now have a permanent effect apparently because their changes are not reverted. fixed on master -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
