https://bugs.freedesktop.org/show_bug.cgi?id=75630
Stephan Bergmann <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected], | |[email protected] --- Comment #4 from Stephan Bergmann <[email protected]> --- The recipe from comment 0 no longer executes the relevant code since integration of <http://cgit.freedesktop.org/libreoffice/core/commit/?id=598d02d71f40901eab9275704c8bc0e1641b56e3> "fdo#75133: Preseved bibliography after round trip," where AttributeOutputBase::StartTOX (sw/source/filter/ww8/ww8atr.cxx) has a dedicated case TOX_AUTHORITIES now. But the line rText = aIt->sText.copy( 0, 5 ); // #i21237# is still there in lcl_CheckForm (sw/source/filter/ww8/ww8atr.cxx), and there may still be other scenarios that might call that with aIt->sText.getLength() < 5? (Before <http://cgit.freedesktop.org/libreoffice/core/commit/?id=f4fd558ac9d61fe06aa0f56d829916ef9e5ee7b9> "String to OUString and some reduction of scope," that code used tools String::Copy(0, 5), which would silently reduce "5" to the given string's actual length, unlike rtl::OUString::copy, which asserts that the requested length does not exceed the actual length. The reference to <https://issues.apache.org/ooo/show_bug.cgi?id=21237> "Q-PCD MSInteroperability-16" got added with <http://cgit.freedesktop.org/libreoffice/core/commit/?id=1c1e93fabc5b840877d118220f0d65363747ffbd> "INTEGRATION: CWS hbqea101 (1.76.76); FILE MERGED: 2004/05/05 09:30:40 hbrinkm 1.76.76.1: #i21237# TOX patterns are vectors of tokens now" and is unrelated to the copy(0, 5) part, which was there since the initial import.) Miklos, do you know whether that copy(0, 5) could ever legitimately be called with a string of length < 5 (and should thus be adapted to rtl::OUString::copy semantics)? -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
