https://bugs.freedesktop.org/show_bug.cgi?id=76181

          Priority: medium
            Bug ID: 76181
          Assignee: [email protected]
           Summary: cleanup constructors in ucalc.cxx
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: [email protected]
          Hardware: Other
            Status: NEW
           Version: 4.2.0.0.alpha0+ Master
         Component: Spreadsheet
           Product: LibreOffice

The calc unit tests pre-date the pretty new string constructors, so we have
lots of this sort of thing:

    m_pDoc->InsertTab(0, OUString("Sheet1"));

Where the 'OUString()' is not needed - and should be removed in favour of a
plain "Sheet1".

Similarly we have a number of:

    OUString aTabName("TestTab");
    m_pDoc->InsertTab(0, aTabName);

Where there is no need for a local variable; we can axe the OUString line and
pass "TestTab" directly in many cases.

Thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to