https://bugs.freedesktop.org/show_bug.cgi?id=77233

          Priority: medium
            Bug ID: 77233
          Assignee: [email protected]
           Summary: DrawGradient improvements in OutputDevice
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: [email protected]
          Hardware: All
            Status: UNCONFIRMED
           Version: 4.3.0.0.alpha0+ Master
         Component: graphics stack
           Product: LibreOffice

DrawGradient has the following issues:

1. There are two functions, one takes a Rectangle parameter, the other a
PolyPolygon parameter. Both functions essentially do the same thing, and the
code is actually so similar that when I slightly reorganized it the only
difference is negligible.

See commit "Starting to bring DrawGradient functions into line with each other"
at
http://cgit.freedesktop.org/libreoffice/core/commit/vcl?id=954d7ad4ea7ec3746b0f0cd3f850a25e82b39c14

2. When you build a gradient, it detects if a metafile is needed. If the
polygon is actually a rectangle, we really should detect this and not bother to
encase the polygon in XGRAD_SEQ_(BEGIN|END) comment headers. 

3. ClipAndDrawGradientMetafile has the option of using XOR clipping. This is
not really desirable for a number of reasons. We should probably
deprecate/remove this from the code. 

4. We have gradient code in other places. Should we move this to the
OutputDevice code perhaps?

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to