https://bugs.freedesktop.org/show_bug.cgi?id=60338

Stephan Bergmann <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #9 from Stephan Bergmann <[email protected]> ---
Ulrich, thanks a lot for your analysis and patch
<https://gerrit.libreoffice.org/#/c/9287/1>.  Looks indeed very plausible that
the uncoordinated calls to umask(3) are causing this.

However, I would prefer to rather get rid of those umask(3) calls.  (That way,
for one, unrelated open(3) calls are not accidentally affected by umask
modifications, and , for another, we likely do not need to introduce new URE
API.)

Looking at the existing umask(3) calls, there is at least three different use
cases:

1  Inside the sal/osl/unx implementation of osl_createTempFile.  This can be
fixed internally in sal/osl.

2  In the implementation of utl::TempFile.  This can hopefully be addressed by
basing the required functionality on osl_createTempFile.

3  In places where Coverity warned about uses of mkstemp "without securely
setting umask first."  I think that Coverity warning is bogus (cf.
<https://communities.coverity.com/message/6516> "Why are uses of mkstemp
'without securely setting umask first' being flagged?") and those calls to
umask should be reverted again

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to