https://bugs.freedesktop.org/show_bug.cgi?id=78536
Michael Stahl <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|[email protected] |[email protected] |desktop.org | CC| |[email protected] Version|4.2.4.2 release |4.2.0.4 release Keywords|have-backtrace |regression Component|Writer |framework --- Comment #5 from Michael Stahl <[email protected]> --- 4.2.0 regression from: commit bcc52fb2ebdf77a1cc089857775fd742085b45b6 Author: Noel Power <[email protected]> AuthorDate: Thu Aug 29 17:15:33 2013 +0100 add support for in-place style preview specifically the additional call to Execute_Impl from ~SfxCommonTemplateDialog_Impl()... there is a ridiculous hack in Execute_Impl to detect if the "this" instance has been deleted, and that hack is not re-entrant, i.e. there are 2 Execute_Impl on the stack now, and the "outer" one will not return early and accesses deleted members. fixed on master. hmm.... now i notice: commit dda842bec338efb06457551136678340d0718807 Author: Noel Power <[email protected]> AuthorDate: Thu Aug 29 17:22:48 2013 +0100 disable/disconnect style preview from styles dialog ... which #ifdefs out a bunch of code, but strangely duplicates the code in ~SfxCommonTemplateDialog_Impl() - i assume this is an accident and it should have been #ifdef'd instead? will push a patch to remove this to master, if i'm wrong it can always be reverted :) -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
