https://bugs.freedesktop.org/show_bug.cgi?id=66170

Jung-uk Kim <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |UNCONFIRMED
     Ever confirmed|1                           |0

--- Comment #2 from Jung-uk Kim <[email protected]> ---
Basically, 512 -> PAGE_SIZE was done in CWS dba32a @ r267346.  The OOo
Subversion[1] says:

------------------------------------------------------------------------
r267346 | oj | 2009-02-04 02:23:26 -0500 (Wed, 04 Feb 2009) | 1 line

#i98701# check key size is >= 3 and some redesign
------------------------------------------------------------------------

It was a fix for i98701[2].  However, it caused compiler warnings in BSDs and
other Unix-like platforms because PAGE_SIZE was redefined.  Therefore, it was
renamed as DINDEX_PAGE_SIZE[3].  While I was reading the original commit (i.e.,
r267346), I realized the author probably wanted real page size for efficiency. 
So, I added a local hack for FreeBSD ports[4].  FYI, I didn't receive a single
complaint about the change for more than a year. :-)

* Note 1: https://code.google.com/a/apache-extras.org/p/ooo-legacy-svn/
* Note 2: https://issues.apache.org/ooo/show_bug.cgi?id=98701
* Note 3: http://cgit.freedesktop.org/libreoffice/core/commit/?id=11ce98
* Note 4:
http://svnweb.freebsd.org/ports/head/editors/libreoffice/files/patch-connectivity__source__inc__dbase__dindexnode.hxx?view=markup&pathrev=321770

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to