https://bugs.freedesktop.org/show_bug.cgi?id=82088
Thomas Arnhold <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Thomas Arnhold <[email protected]> --- Oups, you're right. I accidentally converted this while converting some other star* aliases. Aliases in sources files are ok, but there are many alias definitions inside header files. Those are problematic, because if you rely on this definition in your source (cxx) file you have to always include this header. And much worse: If some other header use this definition you have to account for the order of header includes... Otherwise the build breaks. Commit 150df3c020613bd956c4ad38ab4b5e247801296b fixed such occurrences (those aliases were formerly defined in comphelper...). Here you get a list of all com::sun:: aliases in header files: git grep 'namespace.*=.*com::sun' -- '*.hxx' To your gerrit question: Yes, it is the best way to get your patches in the tree :) So please do it :) -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
