https://bugs.freedesktop.org/show_bug.cgi?id=84846
--- Comment #1 from Boris Egorov <[email protected]> --- I'd like to fix this one. Looks like DrawDocShell::GetObjectIsMarked() and DrawDocShell::GotoTreeBookmark() is almost identical (even the tracing code with method name is the same). I think we can move this code to a new private method (any idea how to name it?) and call it from the old ones. Some bool argument can be used to determine behaviour needed by one of the methods: should we mark object and which boolean to return: bFound or bUnMark. Resulted method would still be huge (~100 lines) and can be reduced further. For example, there are repeating code for taking page number and setting edit mode (DrawDocShell::GotoBookmark() and both aforementioned methods). -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
