https://bugs.freedesktop.org/show_bug.cgi?id=86249
Bug ID: 86249
Summary: clean VirtualDevice constructor ...
Product: LibreOffice
Version: 4.3.0.2 rc
Hardware: Other
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: graphics stack
Assignee: [email protected]
Reporter: [email protected]
The VirtualDevice constructor include/vcl/virdev.hxx has a couple of modes; one
of them looks pretty nasty:
explicit VirtualDevice( const OutputDevice& rCompDev,
sal_uInt16 nBitCount, sal_uInt16
nAlphaBitCount );
It would be great to check all uses of this method, and see if we can't create
a differently named constructor, or even dummy sub-class that has a nicer name
- that expresses what we want there. I suspect nAlphaBitCount is always zero if
present [ but can't be removed because of ambiguity ].
git grep 'new VirtualDevice'
git grep ' VirtualDevice('
It'd be great to cleanup other calls to VirtualDevice constructors to give them
nice names too I guess with thin sub-classes (?).
Thanks !
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
