https://bugs.freedesktop.org/show_bug.cgi?id=42897
--- Comment #10 from Michael Meeks <[email protected]> --- Renato - wow - this is a great patch =) as Joel says gerrit is best. Then again - that code boggles the mind - those huge switch statements seem unbeleivably horrible =) I'd love to kill those by using a prettier lookup table and a small loop to map to/fro - could you submit that first as a pure re-factor (ie. without the new feature). The other thing is - that I don't think we want to touch the global calc conditional formatting type enumeration with a pseudo-type that is isolated to the dialog; so - I think we should append that to the enumeration some way perhaps by having a 'LAST' value in the enum, and using / adding to that in our table inside the dialog code. But - this is exciting progress =) nice work ! looking forward to your gerrit submits, please CC / poke me there ... -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
