https://bugs.freedesktop.org/show_bug.cgi?id=87840
--- Comment #12 from Lionel Elie Mamane <[email protected]> --- (In reply to Julien Nabet from comment #8) > Taking a look to these files, I noticed that hsqldb indicates 4 features: > - UseDOSLineEnds > - FormsCheckRequiredFields > - EscapeDateTime > - AddIndexAppendix > Except that > "lcl_getFeatureMappings" doesn't mention "AddIndexAppendix" Note also that unfortunately sometimes the feature and the property don't have the same name (!). For example property "EnableOuterJoinEscape" is feature "UseBracketedOuterJoinSyntax" (see comments in connectivity/registry/postgresql/org/openoffice/Office/DataAccess/Drivers.xcu). So actually, lcl_getFeatureMappings may not do what you think it does. It may actually be (but that's just a conjecture) the mapping from DSID constants to feature names *only* when the name differs from the property? See for "EnableOuterJoinEscape" / "UseBracketedOuterJoinSyntax": http://opengrok.libreoffice.org/xref/core/dbaccess/source/ui/dlg/DbAdminImpl.cxx#182 Similarly, see for "AddIndexAppendix" see http://opengrok.libreoffice.org/xref/core/dbaccess/source/ui/dlg/DbAdminImpl.cxx#185 which links DSID_INDEXAPPENDIX to "AddIndexAppendix" (I think as a *property* *name*). But lcl_getFeatureMappings has DSID_INDEXAPPENDIX linked to "UseIndexDirectionKeyword". Does that mean that the property in connectivity/registry/hsqldb/org/openoffice/Office/DataAccess/Drivers.xcu should be called "UseIndexDirectionKeyword"? Not sure. Try changing it, does it make a difference? > Moreover, there's no properties in hsqldb file! Possibly "properties" is not "the ones supported", but "the ones that should have a different default value (for connections through this driver) than the Base-wide default". Possibly HSQLDB does not need to change any default. It could be worth checking that. OTOH, I notice that connectivity/registry/ado/org/openoffice/Office/DataAccess/Drivers.xcu has some stuff in "MetaData" (e.g. "ColumnAliasInOrderBy") that I would have expected in "Properties" and that is indeed in "Properties" elsewhere... > I thought about comparing all the Drivers.xcu to: > - check that every one has some properties As per above, not having any property is maybe not an error. I'm not sure. > - check that Features content contains only known id (DSID...) See above -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
