https://bugs.freedesktop.org/show_bug.cgi?id=88230
Bug ID: 88230
Summary: cleanup solar mutex yielding ...
Product: LibreOffice
Version: 4.5.0.0.alpha0+ Master
Hardware: Other
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Libreoffice
Assignee: [email protected]
Reporter: [email protected]
We often want to drop the recursive solar mutex something like this (from the
Vista file-picker):
static void lcl_sleep( ::osl::Condition& aCondition,
::sal_Int32 nMilliSeconds )
{
sal_uLong nAcquireCount = Application::ReleaseSolarMutex();
... do something slow ...
Application::AcquireSolarMutex( nAcquireCount );
}
however - this is a bit ugly - we should instead use:
include/vcl/svapp.hxx:class SolarMutexReleaser
which is also exception safe; and just 1x line ;-) so:
{
SolarMutexReleaser aReleaser; // drop solar mutex
if you do:
git grep -3 AcquireSolarMutex
you can see a load of places to cleanup here.
Thanks !
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
