https://bugs.freedesktop.org/show_bug.cgi?id=85190

--- Comment #46 from Lionel Elie Mamane <[email protected]> ---
(In reply to Stephan Bergmann from comment #43)
> (In reply to Lionel Elie Mamane from comment #42)
> >  catch (java.lang.IncompatibleClassChangeError e2)
> > {
> >     LOGGER.error("Detected an IncompatibleClassChangeError");
> >     throw new com.sun.star.lang.WrappedTargetException(e2, "caught a " +
> > e2.getClass().getName(), this, new
> > com.sun.star.uno.Exception(e2.getLocalizedMessage()));
> > }
> > 
> > to me looks like it will not work, trying to pass a
> > java.lang.IncompatibleClassChangeError through UNO.
> 
> No.  In UNO exception ctors, the optional leading Throwable argument ('e2')
> is only used to pass it as 'cause' argument into the underlying
> java.lang.Throwable ctor; it is not "passed through UNO."

So it is thrown away when the Java exception is caught by the Java UNO bridge,
and the latter throws a UNO exception to whatever called that Java code through
UNO? I see. Thanks for the explanation.

>> Anyway, I improved the message / throwing:
>> http://cgit.freedesktop.org/libreoffice/core/commit/
>> ?id=f4a2cff16ea546e7d0a135d4b061a65e783ab422

> That commit needlessly removes passing in the 'cause' argument.  Please
> revisit.

Readded in
http://cgit.freedesktop.org/libreoffice/core/commit/?cc376d87859a478b6cab348f0c96ea9fa7fe7a9a

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to