https://bugs.documentfoundation.org/show_bug.cgi?id=82688

Lionel Elie Mamane <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #11 from Lionel Elie Mamane <[email protected]> ---
In the particular case of SQLite, it seems we are in a bind. According to my
understanding, primary key support is in the ODBC core grammar, not the minimal
grammar. So LibreOffice is "right" to check for Core grammar support to check
for primary key support. On the other hand, (I understand from Christian
Werner) SQLite does not support parts of the Core grammar, so it is right to
not report Core grammar support.

The SQL92 Entry level grammar includes primary key support, so I'm changing
LibreOffice to assume primary key support if the ODBC Core _OR_ the SQL92 Entry
grammar is supported. It won't help in the case of SQLite because:

 - the ODBC driver does not support GetInfo(..., SQL_SQL_CONFORMANCE, ...)

 - I expect (but don't know for sure) that SQLite doesn't support
   all of the SQL92 entry level grammar anyway, so even if the driver
   supported the above, it would answer "nope, entry level not supported".
   It might be relevant to ask Christian Werner confirmation of this point.
   Julien, you want to do that?


As to why it worked before, it was a "happy accident" from a bug in
LibreOffice, which the commit 94a07be5d726de71315f47d24ef9003991d201ad fixed:
when asked whether the database supported the Core SQL grammar, the ODBC-SDBC
driver checked the level of ODBC API compliance (something unrelated!) and
really answered whether the driver supports the core *API* conformance, which
the SQLite ODBC driver does. So it replied "yes, database supports Core SQL
grammar" although IT DID NOT.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to