https://bugs.documentfoundation.org/show_bug.cgi?id=89482
Justin L <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[email protected] |[email protected] |desktop.org | --- Comment #11 from Justin L <[email protected]> --- fix proposed at https://gerrit.libreoffice.org/#/c/14822/ Notes: 1.) The major part of the fix is in Read_F_Ref - adding a common block of code to ensure that aReferencedTOCBookmarks is updated. 2.) There were still combinations that would cause "duplicate" cross-references to be attempted, so I added _Toc to all cross-ref bookmarks. (docbm.cxx: SAL_WARN("sw.core", "MarkManager::makeMark(..) - refusing to create duplicate CrossRefBookmark") These combinations exist in the updated .doc testfile included in the patch. 3.) The "_Toc" additon will affect all formats, not just .doc. I couldn't find any other way to identify a REF_CONTENT type of .doc bookmark though, and don't think this should cause any regressions. (code search for __Refheading__ | GetCrossRefHeadingBookmarkNamePrefix() | isTOKBookmark | IDocumentMarkAccess::CROSSREF_HEADING_BOOKMARK). Just to be safe, I won't push the crossreference.cxx change to the stable 4.3 branch, meaning that although it will be able to edit existing 4.4.2 authored docs OK, it can't create an original doc with working crossref headers (which it already can't do). Sorry for the initial regression. I hope this patch is better. -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
