https://bugs.documentfoundation.org/show_bug.cgi?id=89643

--- Comment #19 from Julien Nabet <serval2...@yahoo.fr> ---
I noticed this function
http://opengrok.libreoffice.org/xref/core/formula/source/ui/dlg/funcpage.cxx#65
     65 inline sal_uInt16 Lb2Cat( sal_uInt16 nLbPos )
     66 {
     67     // Category 0 == LRU, otherwise Categories == LbPos-1
     68     if ( nLbPos > 0 )
     69         nLbPos -= 1;
     70 
     71     return nLbPos;
     72 }
whereas the only location where this function is called is this:
    114 void FuncPage::UpdateFunctionList()
    115 {
    116     sal_Int32  nSelPos   = m_pLbCategory->GetSelectEntryPos();
    117     const IFunctionCategory* pCategory = static_cast<const
IFunctionCategory*>(m_pLbCategory->GetEntryData(nSelPos));
    118     sal_Int32  nCategory = ( LISTBOX_ENTRY_NOTFOUND != nSelPos )
    119                             ? Lb2Cat( nSelPos ) : 0;

so shouldn't it be:
inline sal_Int32 Lb2Cat( sal_Int32 nLbPos )
to begin with?

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to