https://bugs.documentfoundation.org/show_bug.cgi?id=88230
Michael Meeks <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #12 from Michael Meeks <[email protected]> --- Lovely cleanup - thanks Pranav. Stephan - I agree that the 'clear' method is not ideal - for sure; then again it hardly looks necessary in the current code-base. Pranav - I'd love to get this guy closed; but I still see a few bits that could use some cleanup: fpicker/source/win32/filepicker/SolarMutex.hxx:void AcquireSolarMutex(int nAcquireCount); That thing seems torally bogus; there is no need for this fpicker wrapper - can we kill that ? sw/source/core/view/viewsh.cxx- // Creation, use and destruction of a VirtualDevice needs to be sw/source/core/view/viewsh.cxx- // protected by the SolarMutex, it seems. sw/source/core/view/viewsh.cxx: Application::AcquireSolarMutex(1); And after that I'd love to make the 'AcquireSolarMutex' and release method private methods - and add a 'friend' class for the SolarMutexReleaser and other methods that have a legimitate use for that. -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
