https://bugs.documentfoundation.org/show_bug.cgi?id=88710
--- Comment #4 from Lionel Elie Mamane <[email protected]> --- (In reply to Matthew Nicholls from comment #3) > 1) OSQLParserClient and ODataAccessCharsetHelper depend of functions > createSQLParser and createCharsetHelper respectively, which are not in > dbtools. As a workaround I have added them to dbtools. OK. > 2) There is a similar setup in files sw/inc/swdbtoolsclient.hxx and > sw/source/uibase/dbui/swdbtoolsclient.cxx, would it be desirable for this > to be removed as well? I'm in vacation away from my LibreOffice compilation machine and with bad Internet connection; I'll take a better look when I come back. If the setup is the same, meaning a dlopen()-based wrapper around dbtools, then yes, it is desirable to kill it, too. > 3) If dbtoolsclient and swdbtoolsclient are removed then I cannot see the > use for virtualdbtools.hxx and the files under > connectivity/source/simpledbt/* > Most methods there seem to be small wrappers around dbtools. Fair enough. Make it a separate patch / gerrit change. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
