https://bugs.documentfoundation.org/show_bug.cgi?id=91055

            Bug ID: 91055
           Summary: cleanup weirdo lcl_createWindowInfo method signature
                    ...
           Product: LibreOffice
           Version: 4.4.3.2 rc
          Hardware: Other
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: graphics stack
          Assignee: [email protected]
          Reporter: [email protected]

vcl/source/window/window.cxx has a method:

    OString lcl_createWindowInfo(const vcl::Window& i_rWindow)

which takes a reference that is immediately converted into a pointer to operate
on internally; and all callers pass a de-referenced pointer into it which is
ugly & lame =) it needs changing to:

    OString lcl_createWindowInfo(const vcl::Window *pWindow)

And the callees simplifying =)

Thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to