https://bugs.documentfoundation.org/show_bug.cgi?id=92785
Bug ID: 92785
Summary: Sort configuration on write ...
Product: LibreOffice
Version: 5.0.0.0.beta1
Hardware: Other
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: LibreOffice
Assignee: [email protected]
Reporter: [email protected]
It seems that recently we switched from storing our configuration in a std::map
to an unordered_set or something equivalent. Most likely this has some good
size and performance characteristics - so we want to keep it that way =)
Unfortunately - it also introduces non-determinism when writing the the
instdir/user/registrymodifications.xcu (run an xmllint --format on that before
and after a load and exit to see the difference ;-).
This is not ideal =) Luckily writing that is done asynchronously in its own
thread - so we can use plenty of CPU there.
It would be great to hack:
configmgr/source/writemodfile.cxx
To tackle this sort of iteration (there are several of these in there):
for (NodeMap::const_iterator i(node->getMembers().begin());
i != node->getMembers().end(); ++i)
And to instead have a local function that builds a new sorted vector of the
nodes we want to write. Then if ~nothing changes in the config we can see what
did change.
Thanks ! =)
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
