https://bugs.documentfoundation.org/show_bug.cgi?id=87530

schaber <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |bisected, regression

--- Comment #10 from schaber <[email protected]> ---
93615bca59da819a9b93a6d3b9cc880ac6d9fdfa is the first bad commit
commit 93615bca59da819a9b93a6d3b9cc880ac6d9fdfa
Author: Matthew Francis <[email protected]>
Date:   Sat Mar 14 19:47:06 2015 +0800

    source-hash-5246fa262450f686674850c53df666422f441c86

    commit 5246fa262450f686674850c53df666422f441c86
    Author:     Michael Stahl <[email protected]>
    AuthorDate: Wed May 21 22:26:05 2014 +0200
    Commit:     Michael Stahl <[email protected]>
    CommitDate: Thu May 22 13:12:55 2014 +0200

        fdo#68983: basic: if the library is not loaded fully, copy source
storage

        Also fixes fdo#42899 and fdo#67685 in a different way; the previous fix
        for fdo#42899 caused the problem with password-protected libraries for
        which the password is not known: only the binary representation of the
        BAISC module was stored, not the source code; by simply copying from
the
        source storage the problem can be avoided.

        It would be possible to ask for the password when storing, but that
        would not work when non-interactive (called via API).

        An alternative fix would be to pass in the
        SfxObjectShell::IsSetModifyEnabled() flag and actually reset the BASIC
        library's modify flag correctly, but that requires adding a
        parameter to XStorageBasedLibraryContainer::storeLibrariesToStorage().

        (regression from af34774d260a68fc02cd78ba90dd8d4afaf1a2a4 )

        Change-Id: I4701401f35171139fc2fe8d225d13d4e533091a0

:040000 040000 6e740902a1eae6647cd280d3727938dcac9ee46c
7bbf2b151d50f57c9f2a75075571235ee0c27c9c M    opt

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to