https://bugs.documentfoundation.org/show_bug.cgi?id=82402
--- Comment #14 from Yousuf (Jay) Philips <[email protected]> --- (In reply to Maxim Monastirsky from comment #13) > [Sorry for the long post] Thanks for the detailed explanation. :D > 1. This check seems to be needed only at file close, i.e. a user is closing > the file, while rejecting the changes he made to it. But I wonder why do we > need to refresh the recent list at all at this stage? In order to close a > file, one first needs to open it, isn't it? So the recent item is *already > exists*. I would assume saving a more recent version of the thumbnail to the ODF file, so that new preview could appear in something like a file manager preview would be the intent here, as there wouldnt be a benefit for the start center. > 2. At least when the thumbnail creation method is called upon file open, why > should we care whether the document is flagged as modified (for some > reason), given that we know for sure that the document is just opened, and > the user hadn't a chance to make any manual changes to it? Yep that doesnt make sense to check if the modified flag is set right after LO opens the doc. > 1. The real bug here is that documents are flagged as modified while they're > not. (BTW I looked at SfxObjectShell::IsModified, and it seems that the > modified state comes from the embedded charts. I commented there the code > that checks the status of embedded objects, and this caused all of those > files to show thumbnails in the start center.) Yep this does seem to be the root of the problem (bug 82402). > 2. I don't like the idea of changing a working code (which is always a > recipe for regressions), just to workaround some uncommon cases. We should > consider this only if we'll see a critical mass of documents that won't show > in the start center. We're still not there. This issue came to mind again when i saw a screenshot of the start center with missing thumbnails in a review of 5.0 ( http://me.pcmag.com/libreoffice-50/3008/review/libreoffice-50 ), though it was for calc openable files. http://im.ziffdavisinternational.com/t/pcmag_me/review/l/libreoffic/libreoffice-50_q6rn.320.jpg -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
