https://bugs.documentfoundation.org/show_bug.cgi?id=91362

Christoph Lutz <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #14 from Christoph Lutz <[email protected]> ---
The use case with writer is fixed now. Unfortunately we figured out that the
issue remains for impress. Here the steps to reproduce:

0) I have got a PDF printer installed that supports all common german page
formats A4, A5, ... This printer is used for the test. This is done on linux.

1) create a new impress presentation

2) Format->Page and change page format to e.g. "A5" (I know, it is not typical
to do such things)

3) File->Print --> now look at the preview and see, that A5 is not used now. I
would expect to see the preview already in A5 format.

4) press button "Properties..." for the printersettings. Now I would expect the
disabled comboboxes for size and orientation to show up "A5" and "landscape",
but I get "A4" (my printeres preferred page size) and "landscape".


We also figured out, that the following patch (that is already included in
libreoffice-5-0 and master) solves this issue for draw and impress:

commit 7b31e45ec7106d2cfbdbb7915d97667ba710f81c
Author: Eilidh McAdam <[email protected]>
Date:   Mon Jun 23 20:55:21 2014 +0100

    Make Draw use paper size when printing - fdo#63905

    Previously, Draw/Impress use the default size from the printer.
    Now Draw uses the paper size (specified in page formatting).
    Impress still uses the old method - not sure if this is correct
    but printing handouts etc probably complicate print/paper size.

    Change-Id: If90bae4ac59cd95dd50fcd8deb25fd900756193e
    Reviewed-on: https://gerrit.libreoffice.org/9866
    Reviewed-by: Matúš Kukan <[email protected]>
    Tested-by: Matúš Kukan <[email protected]>

and that this patch breaks the fix again for impress only:

commit f1f89f0202232635e7fbbd7ca47de51755b2bce0
Author: Caolán McNamara <[email protected]>
Date:   Thu Sep 18 11:40:26 2014 +0100

    IsDraw doesn't mean the app/page is Draw

    it means a slide in impress.

    commit 7b31e45ec7106d2cfbdbb7915d97667ba710f81c
    Date:   Mon Jun 23 20:55:21 2014 +0100
        Make Draw use paper size when printing - fdo#63905

        Previously, Draw/Impress use the default size from the printer.
        Now Draw uses the paper size (specified in page formatting).
        Impress still uses the old method - not sure if this is correct
        but printing handouts etc probably complicate print/paper size.

    suggests the intent is for this to not affect Impress and to only
    affect Draw, so this does that

    Change-Id: I481a824ef244fd837992c893f6de0c051af0a26b

So my question is: What is this second patch supposed to do? which issue does
it solve? Can we revert this one?

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to