https://bugs.documentfoundation.org/show_bug.cgi?id=94753
--- Comment #2 from Richard Wordingham <[email protected]> --- Created attachment 119444 --> https://bugs.documentfoundation.org/attachment.cgi?id=119444&action=edit My correction for the bug (file gtksalframe.cxx) My correction is made to Version: 4.4.4.3.0+ in what is recorded as 'Build ID: ec4b4a26b51419ebb60ebb910c2c5b029bd88bd0' There are a number of stylistic problems with my patch that I do not feel able to resolve: 1) I have copied 4 defines and 2 functions from sal/rtl/surrogates.hxx as I could not see a clean way to share them. 2) I have added a static function advpos(). In terms of code, it shares a great deal with OUString::iterateCodePoints(), or rather the function it calls. I can't see how to merge the code in a clean way. In the thread 'Can't track flow of characters in from Input Method Editor', in a post dated 8 October 2015, Caolán McNamara suggested a way to use the latter function directly, at the risk of great inefficiency. 3) If one only requires the code to function according to a strict specification when the strings have not been corrupted by the inclusion of lone surrogates, advpos() can be further simplified. Those options are commented out by means of '#if 0'. Additionally: 4) The modified function GtkSalFrame::IMHandler::signalIMDeleteSurrounding() has only been tested for inputs offset = -1, nchars = +1. -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
