https://bugs.documentfoundation.org/show_bug.cgi?id=91565

Yousuf (Jay) Philips <philip...@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|momonas...@gmail.com        |
           Hardware|Other                       |All
            Version|5.0.0.0.beta1               |3.5.7.2 release
            Summary|REPORT BUILDER: Insert icon |REPORT BUILDER: Missing
                   |not shown                   |insert field icon in Add
                   |                            |Field dialog
                 OS|Linux (All)                 |All

--- Comment #7 from Yousuf (Jay) Philips <philip...@hotmail.com> ---
(In reply to Julien Nabet from comment #5)
> Created attachment 119516 [details]
> screenshot

The icon used for insert button is the broken image icon
(/icon-themes/galaxy/res/grafikde.png), which explains why the icon wasnt
understandable.

(In reply to Julien Nabet from comment #6)
> This code pointer may help to start investigation:
> http://opengrok.libreoffice.org/xref/core/reportdesign/source/ui/dlg/
> CondFormat.src#57

Thanks for the pointer. Looking at link below, you can see that they have only
assigned icons to 3 of the buttons in the dialog and the insert icon is likely
just taking the broken image icon as none was assigned to it.

http://opengrok.libreoffice.org/xref/core/reportdesign/source/ui/dlg/CondFormat.src#94

So i see the broken image icon has always been displayed in galaxy and tango
all the way back to 3.5.7, so this has always been broken. So what is needed is
to decide which icon should be used for the Insert button.

We could use the 'Add Field' icon :-

http://cgit.freedesktop.org/libreoffice/core/plain/icon-themes/galaxy/cmd/lc_addfield.png

http://cgit.freedesktop.org/libreoffice/core/plain/icon-themes/tango/cmd/lc_addfield.png

Would be useful to also change the tooltip from just 'Insert' to 'Insert Field'
or something like that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to