https://bugs.documentfoundation.org/show_bug.cgi?id=95302
Julien Nabet <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Julien Nabet <[email protected]> --- Code pointer: cui/source/dialogs/linkdlg.cxx line 222 222 if( FILEOBJECT & pLink->GetObjType() ) 223 { 224 m_pRbAutomatic->Disable(); 225 m_pRbManual->Check(); 226 m_pRbManual->Disable(); 227 if( OBJECT_CLIENT_GRF == pLink->GetObjType() ) 228 pLinkNm = 0, pFilter = &sLink; 229 } 230 else 231 { 232 m_pRbAutomatic->Enable(); 233 m_pRbManual->Enable(); See http://opengrok.libreoffice.org/xref/core/cui/source/dialogs/linkdlg.cxx#222 Some testing show we go into the if because: 1) #define FILEOBJECT ( OBJECT_CLIENT_FILE & ~OBJECT_CLIENT_SO ) 2) pLink->GetObjType() returns 0x92 (which corresponds to OBJECT_CLIENT_OLE) Several possibilities: 1) Should FILEOBJECT macro be changed to: #define FILEOBJECT ( OBJECT_CLIENT_FILE & ~OBJECT_CLIENT_SO & ~OBJECT_CLIENT_OLE) ? 2) Should pLink be initialized as OBJECT_CLIENT_SO and not OBJECT_CLIENT_OLE ? 3) These kind of links shouldn't be "updateable" indeed and so there's no bug 4) Other? Here are the different types: 50 #ifndef OBJECT_DDE_EXTERN 51 #define OBJECT_INTERN 0x00 52 //#define OBJECT_SO_EXTERN 0x01 53 #define OBJECT_DDE_EXTERN 0x02 54 #endif 55 56 #define OBJECT_CLIENT_SO 0x80 // a Link 57 #define OBJECT_CLIENT_DDE 0x81 58 //#define OBJECT_CLIENT_OLE 0x82 // a Ole-Link 59 //#define OBJECT_CLIENT_OLE_CACHE 0x83 // a Ole-Link with SvEmbeddedObject 60 #define OBJECT_CLIENT_FILE 0x90 61 #define OBJECT_CLIENT_GRF 0x91 62 #define OBJECT_CLIENT_OLE 0x92 // embedded link See http://opengrok.libreoffice.org/xref/core/include/sfx2/lnkbase.hxx#50 Michael: any thoughts or any idea who may help here? -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
