https://bugs.documentfoundation.org/show_bug.cgi?id=96099
Bug ID: 96099
Summary: Reduce number of typedefs used for trivial container
types
Product: LibreOffice
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: LibreOffice
Assignee: [email protected]
Reporter: [email protected]
Our code uses typedefs for trivial containers of simple types here and there,
like std::vector<int>, std::vector<sal_Int32>, std::vector<OUString>. Such
typedefs are not necessarily helpful, but just make the code harder to read and
understand.
Also, the naming of the typedefs is far from uniform. Some that use std::vector
are called "list", others "stack", others "vector". Both "list" and "stack"
have specific meanings already in the C++ library, so using such a name for a
std::vector is misleading.
The task here is to get rid of such silly typedefs. Just use the
std::vector<whatever> instead, etc. When applicable, use 'auto' for the
iterator types of the container. Etc.
Please do this for just a handful of cases at a time. Obviously you should test
compile your changes before submitting.
Reviewers, please make sure that suggested patches don't misunderstand the task
and actually make the code worse. (Sure, I know that might be a matter of
taste.)
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
