https://bugs.documentfoundation.org/show_bug.cgi?id=90214
--- Comment #8 from V Stuart Foote <[email protected]> --- (In reply to Joel Madero from comment #7) > Be my guest - saying "do more" is not sufficient to hold back a patch. As it > stands the color scheme is horrible for dark themes. This resolves that > issue. If you want to do more though, I'm not going to stop you. Absent > that, I hope that a patch isn't held back because there should be a larger > change (done at some unknown time at some point in the future by a yet > unknown developer). No, I'm only questioning doing something overly simplistic now, when correct handling should really not be that much more complicated. IIUC the issue only manifests when defaults for the colorscheme are not being overloaded when using an OS/DE with dark theme. Why is that? Is it simply not defined in the theme(s), or just not being mapped onto the element colors defined in app/settings.cxx? There are a few ways to tackle this, but a one off change in color assignment is probably not the best way. It muddles the default colors and those of and any lighter theme, and I am not so sure it fully corrects things for the Dark themes. I suspect we need to fix the methods for passing settings from OS/DE theme -> colorscheme mapping, especially for the dark themes. And as suggested, another way would be to expose these color controls to the GUI and to the Expert Config dialogs. -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
