https://bugs.documentfoundation.org/show_bug.cgi?id=92157
Mike Kaganski <mikekagan...@hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.documentfounda
| |tion.org/show_bug.cgi?id=95
| |775
--- Comment #21 from Mike Kaganski <mikekagan...@hotmail.com> ---
(In reply to libreoffice from comment #15)
> I've investigated the problem for this document, and it's that the document
> has a graphic with size 0, 0. (It contains the xml
> <a:graphic...<a:xfrm><a:off x="0" y="0"/><a:ext cx="0" cy="0"/></a:xfrm>).
> This fails the test in SwFormatFrmSize::PutValue (MID_FRMSIZE_SIZE) which
> makes SfxItemPropertySet::setPropertyValue throw an
> IllegalArgumentException, aborting the parser.
>
> The attached patch skips setting the graphic size if the size is 0, 0. With
> this patch applied I can open the document.
The fix for bug 95775 already relaxed the abovementioned test in
SwFormatFrmSize::PutValue (now it only checks if one of the two values (either
x or y) is not 0). That relaxation is apparently not enough for this particular
issue; but I beleive that the proper fix here would be not to avoid setting the
size as in the patch attached to comment 15, but to completely remove the check
from SwFormatFrmSize::PutValue.
libreoff...@arbruijn.dds.nl, please move on and post improved patch to gerrit.
If you cannot do it, I'll prepare a patch around jan 15th, with proper credit
to you. Thank you for your work!
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
