https://bugs.documentfoundation.org/show_bug.cgi?id=96971
Bug ID: 96971
Summary: SetXORMode - remove un-needed parameter ...
Product: LibreOffice
Version: 5.1.0.1 rc
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: graphics stack
Assignee: [email protected]
Reporter: [email protected]
If you do a:
git grep -5 SetXORMode
in VCL - you'll see that the second parameter:
virtual void SetXORMode( bool bSet, bool bInvertOnly )
bInvertOnly - appears to only be implemented for OSX - and all the other
backends just use 'bSet' - to mean "XOR" vs. "Not XOR".
As such - it'd be great to go back through the callees and check that no-one is
really using bInvertOnly in anger, and then strip that parameter out of the
backend APIs, and also out of the VCL API in each instance; and ideally out of
any callers that use bInvertOnly.
That is - unless there is indeed a use-case for this =) (I suspect not).
Thanks !
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
