https://bugs.documentfoundation.org/show_bug.cgi?id=97228

--- Comment #1 from Chris Sherlock <[email protected]> ---
There might be a little confusion around this one for newbies. 

include/vcl/salnativewidgets.hxx is used for any module that needs to access
specific classes or functions of VCL. You'll see what sort of things need this
because there is a SAL_DLLPUBLIC decorator in the class or function. 

If the class/function doesn't have a SAL_DLLPUBLIC attribute decorating it,
then there is a good chance that it should be moved to the "private" vcl
headers, which are found at vcl/inc/* - Tor's suggestion is to move them into
vcl/inc/nativewidgets.hxx - but don't feel constrained in this - if there is a
better header filename then try this instead. If it's wrong, then it's wrong
and we'll advise you - but if you think it's more specialized then there is a
good likelihood it's better off in a different header!

As an example, there is a class called ControlCacheKey:

http://opengrok.libreoffice.org/xref/core/include/vcl/salnativewidgets.hxx#257

Clicking on the link and searching for symbols that reference it in OpenGrok
shows that only vcl uses it. In this case, it's probably a good candidate to
move into vcl/inc/nativewidgets.hxx

Any file that references this class should then include the new header with the
syntax:

#include "nativewidgets.hxx"

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to