https://bugs.documentfoundation.org/show_bug.cgi?id=84985
Regina Henschel <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Regina Henschel <[email protected]> --- The reason is clear, but not the solution. Reason: The calculation in line#161 in method ToolboxButtonColorUpdater::Update in file svx\source\tbxctrls\tbxcolorupdate.cxx uses implicit integer arithmetic, and the implementation of point, size and rectangle in tools/gen.cxx seems to assume integer row and column numbers instead of a coordinate system. If the icon size is a multiple of 4, there are no rounding problems. Problems are for icon size 22×22 and for icon size 26×26 We have: Breeze, Elementary, Human, Industrial, Sifr, Tango: 24×24, no problem Crystal: 22×22, are not delivered, has no such icon, no problem Oxygen: 22×22. Vertical update range row 16..20. Calculation height of update range = 22 / 4 = 5, OK Calculation of top = 22 * 3 / 4 = 66 /4 = 16. OK The icons in Oxygen are transparent in pixel row 21. Galaxy, High contrast: 26×26 Vertical update range row 20..25 Calculation height of update range = 26 / 4 = 6, OK Calculation of top = 26 * 3 / 4 = 78 / 4 = 19. Wrong. Problem: It is not possible to generally round up, or to generally count from the bottom row, because it then does not fit for Oxygen. Possible solution: (A) Make the calculation depend on number of pixel rows (22/26/others). (B) Move the update range in Galaxy and High Contrast one pixel up. (C) Reduce the icon size in Galaxy and High Contrast for these icons to 24×24. The theme Galaxy has already some icons of size 24×24. Suggestion? -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
