https://bugs.documentfoundation.org/show_bug.cgi?id=97973
Bug ID: 97973
Summary: cleanup spinbuttons theming logic.
Product: LibreOffice
Version: 5.1.1.1 rc
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: graphics stack
Assignee: [email protected]
Reporter: [email protected]
SpinButtons used to (erroneously) pass in an empty rectangle as their control
region. This was fixed in:
commit 469ce3ed324c784a2af1e2fdb0a1f09e28170def
Author: Michael Meeks <[email protected]>
Date: Wed Feb 17 20:42:52 2016 +0000
tdf#97922 - get control area right for spinbuttons.
But there is still a lot of ugliness undoing this lower down the theming stack
and around the place =) it would be fantastic to remove that.
Checkout vcl/unx/kde4/KDESalGraphics.cxx which has a special case to build the
widgetRect for spin-buttons that can now be cleaned up.
Similarly vcl/unx/gtk/salnativewidgets-gtk.cxx has // CTRL_SPINBUTTONS pass
their area in pSpinVal, not in rControlRectangle
That comment is now wrong, and we can dung out that special case too.
Worth also removing the commented out code in salnativewidgets-luna.cxx //
decrease spinbutton rects a little.
Please see bug#97922 for a way to test the spin-buttons in the Change Icon
dialog =)
Thanks !
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
