https://bugs.documentfoundation.org/show_bug.cgi?id=96896

Michael Meeks <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |difficultyInteresting,
                   |                            |easyHack, skillCpp
                 CC|                            |[email protected]

--- Comment #8 from Michael Meeks <[email protected]> ---
Looks like a silly infinite recursion:

mergedlo!SfxBaseController::getTitle+0x4f
mergedlo!framework::TitleHelper::impl_updateTitleForController+0x239
mergedlo!framework::TitleHelper::impl_updateTitle+0x19d
mergedlo!framework::TitleHelper::getTitle+0x96
mergedlo!SfxBaseController::getTitle+0x4f

It is possible that this fixes it:

--- a/framework/source/fwe/helper/titlehelper.cxx
+++ b/framework/source/fwe/helper/titlehelper.cxx
@@ -417,7 +417,8 @@ void TitleHelper::impl_updateTitleForController (const
css::uno::Reference< css:
         xModelTitle.set(xController, css::uno::UNO_QUERY);
     if (xModelTitle.is ())
     {
-        sTitle.append      (xModelTitle->getTitle ());
+        if (!init) // avoid recursion.
+            sTitle.append      (xModelTitle->getTitle ());
         if ( nLeasedNumber > 1 )
         {
             sTitle.append (" : ");

But that needs testing, and we need a unit test for it - which we should add to 

framework/complex/ModuleManager/CheckXModuleManager.java

or perhaps a copy of that - operating on the frame there.
 => turning into an easy hack =)

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to