https://bugs.documentfoundation.org/show_bug.cgi?id=96896
--- Comment #22 from Michael Meeks <[email protected]> --- akash96j - this work looks extremely thorough and helpful =) Thank you ! Please can you do the following: a) split each of your patches that fixes a bug into a separate commit; it also helps to commit them with some separation too - to help later QA people bibisect to the right one. b) include your rational - a few lines; and tdf#1234 for the bug in the first-line to make it easy to reference them. c) include a unit test for each category of fix; it should be possibly to adapt an existing test here I think - but at least, where there is significant unclarity about what it is supposed to do, tests are even more vital - so we can be sure we don't regress in future. Otherwise - the fixes look plausible to me; do they pass 'make check' =) if so, with the above; lets get them in. Great work & analysis; sorry it took a while to get to review this, and sorry that this was in no way an 'Easy' easy-hack =) -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
