https://bugs.documentfoundation.org/show_bug.cgi?id=67302

--- Comment #6 from Lionel Elie Mamane <[email protected]> ---
In connectivity/source/drivers/*, each directory should contain one
implementation of getTables() from the XTablesSupplier interface. This does not
concern the getTables from the XDatabaseMetaData interface.

See
 
http://api.libreoffice.org/docs/idl/ref/interfacecom_1_1sun_1_1star_1_1sdbc_1_1XDatabaseMetaData.html#aee9c7e3149e149b3694c900bd6a0671f
 
http://api.libreoffice.org/docs/idl/ref/interfacecom_1_1sun_1_1star_1_1sdbcx_1_1XTablesSupplier.html#a364c9ed144725a9c2fdb159e2c201e19

The easy way to make the difference between the two is that the one we care
about in this bug does not take any arguments, while the other one does. So we
need to look for (e.g. with "git grep") getTables definitions and invocations
without any argument.

Each needs to be changed. Then everywhere getTables (without arguments) is
*called* needs to be changed.

For the first part, the likely matches are:
 connectivity/source/drivers/evoab2/NCatalog.cxx
 connectivity/source/drivers/kab/KCatalog.cxx
 connectivity/source/drivers/macab/MacabCatalog.cxx
 connectivity/source/drivers/mork/MCatalog.cxx
 connectivity/source/drivers/postgresql/pq_connection.cxx
 connectivity/source/sdbcx/VCatalog.cxx
 dbaccess/source/core/api/SingleSelectQueryComposer.cxx
 dbaccess/source/core/api/querycomposer.cxx
 dbaccess/source/core/dataaccess/connection.cxx
 dbaccess/source/core/dataaccess/datasource.cxx

When these return a pre-made object (which I expect to be common), you need to
go look where that object is created. For example, according to comment 0, for
postgresql/pq_connection.cxx, this is in pq_xtables.cxx function
Tables::refresh

I suggest you take them one by one, and we can discuss them one by one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to