https://bugs.documentfoundation.org/show_bug.cgi?id=100302

            Bug ID: 100302
           Summary: warning: "_FILE_OFFSET_BITS" redefined in pyuno
                    modules on SunOS i386
           Product: LibreOffice
           Version: 5.1.3.2 release
          Hardware: x86 (IA32)
                OS: Solaris
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: LibreOffice
          Assignee: [email protected]
          Reporter: [email protected]

I'm noticing the following in lo builds on SunOS i386 (pkgsrc):
[build CXX] pyuno/source/module/pyuno_module.cxx
In file included from
/tmp/pkgsrc/misc/libreoffice/work/.buildlink/include/python2.7/Python.h:8:0,
                 from
/tmp/pkgsrc/misc/libreoffice/work/libreoffice-5.1.3.2/pyuno/source/module/pyuno_impl.hxx:27,
                 from
/tmp/pkgsrc/misc/libreoffice/work/libreoffice-5.1.3.2/pyuno/source/module/pyuno.cxx:46:
/tmp/pkgsrc/misc/libreoffice/work/.buildlink/include/python2.7/pyconfig.h:1169:0:
warning: "_FILE_OFFSET_BITS" redefined
 #define _FILE_OFFSET_BITS 64
 ^
In file included from /usr/include/iso/stdlib_iso.h:49:0,
                 from /usr/include/stdlib.h:37,
                 from
/tmp/pkgsrc/misc/libreoffice/work/libreoffice-5.1.3.2/include/sal/config.h:27,
                 from
/tmp/pkgsrc/misc/libreoffice/work/libreoffice-5.1.3.2/pyuno/source/module/pyuno.cxx:20:
/usr/include/sys/feature_tests.h:231:0: note: this is the location of the
previous definition
 #define _FILE_OFFSET_BITS 32
 ^
In file included from
/tmp/pkgsrc/misc/libreoffice/work/.buildlink/include/python2.7/Python.h:8:0,
                 from
/tmp/pkgsrc/misc/libreoffice/work/libreoffice-5.1.3.2/pyuno/source/module/pyuno_impl.hxx:27,
                 from
/tmp/pkgsrc/misc/libreoffice/work/libreoffice-5.1.3.2/pyuno/source/module/pyuno_struct.cxx:33:
/tmp/pkgsrc/misc/libreoffice/work/.buildlink/include/python2.7/pyconfig.h:1169:0:
warning: "_FILE_OFFSET_BITS" redefined
 #define _FILE_OFFSET_BITS 64
 ^
In file included from /usr/include/iso/stdlib_iso.h:49:0,
                 from /usr/include/stdlib.h:37,
                 from
/tmp/pkgsrc/misc/libreoffice/work/libreoffice-5.1.3.2/include/sal/config.h:27,
                 from
/tmp/pkgsrc/misc/libreoffice/work/libreoffice-5.1.3.2/pyuno/source/module/pyuno_struct.cxx:20:
/usr/include/sys/feature_tests.h:231:0: note: this is the location of the
previous definition
 #define _FILE_OFFSET_BITS 32
 ^
[build CXX] pyuno/source/module/pyuno_type.cxx
[build CXX] pyuno/source/module/pyuno_util.cxx
[build CXX] pyuno/source/module/pyuno_except.cxx
[build CXX] pyuno/source/module/pyuno_adapter.cxx
[build CXX] pyuno/source/module/pyuno_gc.cxx
[build CXX] pyuno/source/module/pyuno_iterator.cxx
In file included from
/tmp/pkgsrc/misc/libreoffice/work/.buildlink/include/python2.7/Python.h:8:0,
                 from
/tmp/pkgsrc/misc/libreoffice/work/libreoffice-5.1.3.2/pyuno/source/module/pyuno_impl.hxx:27,
                 from
/tmp/pkgsrc/misc/libreoffice/work/libreoffice-5.1.3.2/pyuno/source/module/pyuno_iterator.cxx:24:
/tmp/pkgsrc/misc/libreoffice/work/.buildlink/include/python2.7/pyconfig.h:1169:0:
warning: "_FILE_OFFSET_BITS" redefined
 #define _FILE_OFFSET_BITS 64
 ^
In file included from /usr/include/iso/stdlib_iso.h:49:0,
                 from /usr/include/stdlib.h:37,
                 from
/tmp/pkgsrc/misc/libreoffice/work/libreoffice-5.1.3.2/include/sal/config.h:27,
                 from
/tmp/pkgsrc/misc/libreoffice/work/libreoffice-5.1.3.2/pyuno/source/module/pyuno_iterator.cxx:20:
/usr/include/sys/feature_tests.h:231:0: note: this is the location of the
previous definition
 #define _FILE_OFFSET_BITS 32
 ^


The cause is that these pyuno modules include <sal/config.h> first which has:
>#if defined LIBO_INTERNAL_ONLY
>#include "config_global.h"
>#endif
>
>#include <stdlib.h>

config_global.h, even if LIBO_INTERNAL_ONLY, does not seem to deal with
the primary configuration time necessary macros, namely:
...
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... 64
...

So naturally stdlib.h already performs the feature_tests and fixes in
concrete 32-bit runtime functions instead of the largefile functions.
Redefining the macro later is useless because of the system header guards
avoiding multiple inclusion issues.

perhaps one or more of the config_host header files generated should
include the configuration determined value of _FILE_OFFSET_BITS and 
be consequently included by config_global.h in order to not defeat the
purpose of configuration in the first place.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to