https://bugs.documentfoundation.org/show_bug.cgi?id=97087
--- Comment #22 from Tor Lillqvist <[email protected]> ---
I have a better idea about naming Timer and Idle instances:
Let's not try to come up manually with names at all. What is the intended use
case for these names, after all?
Isn't it like this: you see in SAL_INFO output some information like "timer
'Mumble Frobozzinication Timer' fired". What is the next thing you do? You git
grep for "Mumble Frobozzinication Timer" to find the place where it is created
and then search more around that for what is done to it.
Why not get rid of that 'git grep' stage and directly encode the file name,
line number, and instance count in the name of the timer?
We would need some function like comphelper::MakeUniqueInstanceId(const char
**file, int line) that would be called where Timer objects are constructed like
MakeUniqueInstanceId(__FILE__, __LINE__).
It and would generate a string like "sc-source-foo-bar-mumble-cxx-123-4", where
123 would be the line number, and 4 a counter of how many times a timer has
been constructed at that line.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
