https://bugs.documentfoundation.org/show_bug.cgi?id=100458

--- Comment #7 from Jan-Marek Glogowski <[email protected]> ---
So my latest Gerrit patch @ https://gerrit.libreoffice.org/#/c/26435/ simply
removes this line. At the end I still don't know the expected behaviour.

Commit 61c39eae570d6d6040b65bfe93127b30e6080cc8 introduced the overwriting cell
type as a workaround.

// If a matrix formula has a matrix reference cell that is intended to have
// a blank text result, the matrix reference cell is actually saved(export)
// as a float cell with 0 as the value and empty <text:p/>.

This is the same in my document AKA 
 <table:table-cell office:value-type="float" office:value="0">
   ... annotation
   <text:p/>
  </table:table-cell>

And strangely this overwriting was just done exactly for this case, with the
quoted comment in front of the code:

+    if( rStr.isEmpty() )
+    {
+        rnCellType = util::NumberFormat::TEXT;

The current code expands the overwriting to a broader range of cases
(sc/source/filter/xml/xmlcelli.cxx:1511), and this might also be wrong.
Actually my document works correctly _without_ any special handling of cell
number type, just by resetting the text, and breaks _with_ the overwrite.

// Import works around this by setting these cells as text cells so that
// the blank text is used for display instead of the number 0.

This reads as we already fix the import problem with a workaround, and if the
comment is correct, it's not needed any more, which is proved by my error case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to